[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 23 02:20:48 PST 2021


kbobyrev added a comment.

In D114370#3148143 <https://reviews.llvm.org/D114370#3148143>, @sammccall wrote:

> The ReferencedFiles is designed to make add() as cheap as possible, and do any per-file logic after folding the fileIDs together.
> This keeps that loop tighter and also isolates the complexity of the symbol vs file logic.
> Any reason we can't do that here?

Good point, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114370/new/

https://reviews.llvm.org/D114370



More information about the cfe-commits mailing list