[PATCH] D113107: Support of expression granularity for _Float16.

[Phoebe Wang via Phabricator via cfe-commits]

pengfei added inline comments.


================
Comment at: clang/test/CodeGen/X86/Float16-aritmetic.c:8-9
+  // CHECK: alloca half
+  // CHECK: store half {{.*}}, half*
+  // CHECK: store half {{.*}}, half*
+  // CHECK: load half, half*
----------------
zahiraam wrote:
> pengfei wrote:
> > This isn't correct without the ABI code change. I did some work in D107082. I plan to refactor (if I have enough time)
> If this the output we want to generate, should the changes D107082 happen before the changes in this patch?
I think I made a mistake. This is correct, though if probably crashes in backend without D107082.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113107/new/

https://reviews.llvm.org/D113107