[PATCH] D114254: [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges

Whisperity via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 22 01:49:27 PST 2021


whisperity added inline comments.


================
Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp:102
+  EXPECT_EQ("invalid->invalid", Errors[0].Message.Message);
+  EXPECT_EQ(0ul, Errors[0].Message.Ranges.size());
+
----------------
`EXPECT_TRUE(Errors[0].Message.Ranges.empty());`? But I'm not sure if the data structure used there supports this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114254/new/

https://reviews.llvm.org/D114254



More information about the cfe-commits mailing list