[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

Matheus Izvekov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 18 16:10:49 PST 2021


mizvekov added a comment.

In D110216#3139129 <https://reviews.llvm.org/D110216#3139129>, @lkail wrote:

> Hi we found regression in our internal tests. It compiles with clang-13.0.0 https://godbolt.org/z/3abGrcf7o and gcc https://godbolt.org/z/K9oj3Grs1, but fails with clang-trunk https://godbolt.org/z/1Tehxa1x9. Is it an intended change? If so, do we have to document this?

Thanks for the report!

No it was not intended change, this patch should not affect partial ordering like that, modulo any bugs we might have accidentally fixed.
What happened here is that we lost a very small piece of code in the refactoring, which was introduced more than 10 years ago, but had no test coverage.
You just provided it though, and I am working on a patch to restore it shortly.

In D110216#3140678 <https://reviews.llvm.org/D110216#3140678>, @thakis wrote:

> Haha :) Thanks for taking a look. aka for typedefs sounds like a nice approach to me.

Thanks, low on bandwidth right now but I will get to it :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110216/new/

https://reviews.llvm.org/D110216



More information about the cfe-commits mailing list