[PATCH] D114318: [clang] Add missing CPUID feature bit masks

Sun Nov 21 04:38:18 PST 2021

pengfei added a subscriber: hjl.tools.
pengfei added a comment.

> bit_HYPERVISOR: This seems to be standardized. See the following links:

I'm not sure what are these bits defined according to. From PV of HW, I think this shouldn't be added. This bit is set by hypervisor rather than CPU like others. And I found this bit is still 0 in my VM.

> bit_IA57: Appears to be defined in June 2021 Intel SDM at Vol. 2A 3-219 (PDF page 794).

Oh, I missed that. Thanks.

GCC has the same (but fewer) definitions, https://github.com/gcc-mirror/gcc/blob/master/gcc/config/i386/cpuid.h
+ at hjl.tools to have a look.

================
Comment at: clang/lib/Headers/cpuid.h:159
+#define bit_RDTM            0x00001000
+#define bit_DEPRFPUCSDS     0x00002000
+#define bit_MPX             0x00004000
----------------
`DEPR_FPU_CSDS` ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114318/new/

https://reviews.llvm.org/D114318