[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

Sat Nov 20 07:30:34 PST 2021

jamesfarrell added a comment.

In D114163#3143534 <https://reviews.llvm.org/D114163#3143534>, @danalbert wrote:

> Nice, that's a lot of code cleaned up! LGTM, but probably should wait for someone from Apple to weigh in. I think the new formatting for those error messages is better for them too but that's not my call :)

Agreed on both counts. While I generally tried to be careful to preserve existing behavior, it seemed to me that "x86_64-apple-macosx10.9" (for example) should have the version reported in error messages as "10.9", not "10.9.0". But definitely need to hear from someone at Apple about that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114163/new/

https://reviews.llvm.org/D114163