[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 19 11:12:03 PST 2021


vsapsai added inline comments.


================
Comment at: clang/lib/Serialization/ASTWriter.cpp:873
   RECORD(PP_TOKEN);
+  RECORD(PP_INCLUDED_FILES);
 
----------------
I believe `PP_INCLUDED_FILES` is located in `AST_BLOCK`. Yes, you write it in `ASTWriter::WritePreprocessor` but after `Stream.ExitBlock()` together with `MACRO_OFFSET`. And then you read it in `ASTReader::ReadASTBlock` at the top level and not inside `case PREPROCESSOR_BLOCK_ID` or from `ModuleFile::MacroCursor`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114095/new/

https://reviews.llvm.org/D114095



More information about the cfe-commits mailing list