[PATCH] D114229: [clang][driver] Always add LTO options when using GNU toolchain

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 19 07:50:48 PST 2021


tejohnson added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:558
     assert(!Inputs.empty() && "Must have at least one input.");
     addLTOOptions(ToolChain, Args, CmdArgs, Output, Inputs[0],
                   D.getLTOMode() == LTOK_Thin);
----------------
This will add a whole lot of options besides -plugin, which is the only thing guarded against for lld. But in general I'm not in favor of adding a dependence on having the LTO plugin available to all non-lld links by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114229/new/

https://reviews.llvm.org/D114229



More information about the cfe-commits mailing list