[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang
Zarko Todorovski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 19 07:07:07 PST 2021
ZarkoCA marked 3 inline comments as done.
ZarkoCA added a comment.
In D114025#3142565 <https://reviews.llvm.org/D114025#3142565>, @aaron.ballman wrote:
> In D114025#3141414 <https://reviews.llvm.org/D114025#3141414>, @keryell wrote:
>
>> In D114025#3140192 <https://reviews.llvm.org/D114025#3140192>, @Quuxplusone wrote:
>>
>>> I think "sanity-check" could be reasonably replaced with "smoke-test," but (1) this PR doesn't do that, and (2) the phrase "smoke-test" is probably //harder// to understand,
>>
>> It seems difficult considering the potential atmospheric pollution, carbon footprint, health issues, lung cancer, drug abuse, etc. implied.
>
> This is not a constructive comment either, please stop.
>
> In D114025#3141358 <https://reviews.llvm.org/D114025#3141358>, @ZarkoCA wrote:
>
>> @Quuxplusone Thanks for thorough review.
>
> +1, you caught some stuff I was glossing over, but this is much improved. I made a few tiny suggestions (take them or leave them). Continues to LGTM
Yes, agreed, the suggestions made this much better. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114025/new/
https://reviews.llvm.org/D114025
More information about the cfe-commits
mailing list