[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

Manoj Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 18 20:31:01 PST 2021


manojgupta added a comment.

> More subjective: for most users this whole -march business is abstracted away in build systems, so they won't have to deal with this, that's why this isn't so much of an improvement.



> If we want a better user experience set options, there are probably other things that are more important, like checking legal/illegal architecture combinations.



> So, in summary, we prefer not to go ahead with this. And the precedent that was mentioned, -mcrc, should probably be deprecated.

I'd argue the contrary that the current way of -march=isa+feature is broken. I am yet to see a build system that understands or processes the values inside march arguments. And this blocks users from choosing custom hw features without resorting to terrible hacks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113779/new/

https://reviews.llvm.org/D113779



More information about the cfe-commits mailing list