[PATCH] D113917: Add infrastructure to support matcher names.

James King via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 18 14:26:48 PST 2021


jcking1034 marked an inline comment as done.
jcking1034 added inline comments.


================
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1022
+  std::string getName() const override {
+    return "HasOverloadedOperatorNameMatcher";
+  }
----------------
ymandel wrote:
> here and below: drop the "Matcher" suffix?
Done. I've realized that this is a separate issue, but I'm still somewhat concerned about how the `HasOverloadedOperatorNameMatcher` is used in two different matchers, such that both `hasOverloadedOperatorName` and `hasAnyOverloadedOperatorName` will both have the name "HasOverloadedOperatorName".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113917/new/

https://reviews.llvm.org/D113917



More information about the cfe-commits mailing list