[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 18 14:06:05 PST 2021


Quuxplusone added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:22443
+               Style);
+}
+
----------------
Quuxplusone wrote:
> I'd like to see `module :private;`
> I'd like to see `import <foo/bar.h>;`
> I'd like to see `import foo...bar;`
> I'd like to see `import ..........;`
> Is `module foo:private;` a thing?
> Is `module public:while;` a thing?
I don't intend to block this PR waiting on //fixing// these, but please at least add the "I'd like to see" test cases with `TODO` comments. That way, whoever tackles it will have the test cases already written.

As usual, I'm ambivalent about the "Is X a thing?" test cases — they arguably don't matter but arguably should be tested anyway to make sure clang-format doesn't crash on them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114151/new/

https://reviews.llvm.org/D114151



More information about the cfe-commits mailing list