[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

Thu Nov 18 12:44:16 PST 2021

HazardyKnusperkeks added a comment.

In D114142#3139756 <https://reviews.llvm.org/D114142#3139756>, @MyDeveloperDay wrote:

> I'm thinking that those cases are handled else where
>
> as S=1 on those elements (which means space required before)
>
>   M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=double L=6 PPK=2 FakeLParens=2/ FakeRParens=0 II=0x1d662dd3990 Text='double'
>   M=0 C=1 T=StartOfName S=1 F=0 B=0 BK=0 P=220 Name=identifier L=11 PPK=2 FakeLParens= FakeRParens=0 II=0x1d662dc9488 Text='term'
>   M=0 C=0 T=BinaryOperator S=1 F=0 B=0 BK=0 P=22 Name=equal L=13 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='='
>   M=0 C=1 T=Unknown S=1 F=0 B=0 BK=0 P=22 Name=identifier L=15 PPK=2 FakeLParens=14/ FakeRParens=0 II=0x1d662dc94b8 Text='a'
>   M=0 C=0 T=BinaryOperator S=1 F=0 B=0 BK=0 P=34 Name=star L=17 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='*'
>   M=0 C=0 T=LineComment S=1 F=0 B=0 BK=0 P=34 Name=comment L=26 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='// first'
>   M=1 C=1 T=Unknown S=1 F=0 B=0 BK=0 P=1020 Name=identifier L=106 PPK=2 FakeLParens= FakeRParens=2 II=0x1d662dc94e8 Text='b'
>   M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=23 Name=semi L=107 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text=';'
>
>
>
>   M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=void L=4 PPK=2 FakeLParens= FakeRParens=0 II=0x1d662dd3e28 Text='void'
>   M=0 C=1 T=FunctionDeclarationName S=1 F=0 B=0 BK=0 P=80 Name=identifier L=8 PPK=2 FakeLParens= FakeRParens=0 II=0x1d662dc93f8 Text='foo'
>   M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=23 Name=l_paren L=9 PPK=1 FakeLParens= FakeRParens=0 II=0x0 Text='('
>   M=0 C=1 T=Unknown S=0 F=0 B=0 BK=0 P=140 Name=int L=12 PPK=2 FakeLParens=1/ FakeRParens=0 II=0x1d662dd3b40 Text='int'
>   M=0 C=1 T=PointerOrReference S=1 F=0 B=0 BK=0 P=230 Name=star L=14 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='*'
>   M=0 C=0 T=LineComment S=1 F=0 B=0 BK=0 P=54 Name=comment L=35 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='// this is the first'
>   M=1 C=1 T=Unknown S=0 F=0 B=0 BK=0 P=1040 Name=comma L=115 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text=','
>   M=0 C=1 T=Unknown S=1 F=0 B=0 BK=0 P=41 Name=int L=119 PPK=2 FakeLParens= FakeRParens=0 II=0x1d662dd3b40 Text='int'
>   M=0 C=1 T=StartOfName S=1 F=0 B=0 BK=0 P=240 Name=identifier L=126 PPK=2 FakeLParens= FakeRParens=1 II=0x1d662dc9518 Text='second'
>   M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=43 Name=r_paren L=127 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text=')'
>   M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=23 Name=semi L=128 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text=';'

I only now this from the tests with `-debug`. Is there a way to get "normal" clang-format to print these? Or did you write a test for that to print the information?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114142/new/

https://reviews.llvm.org/D114142