[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 18 09:04:36 PST 2021


jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai.
jansvoboda11 added a comment.

Still a WIP, but might be get some feedback on the direction.

I'm not 100% sure when to consider a search path that triggered the creation of `Module` as used. Doing so on `Module` creation is not useful, since we do that (somewhat) eagerly. The current approach marks search path as used whenever it's responsible for the creation of a `Module` that gets returned by `HeaderSearch::lookupModule`. That's not correct in situations when a `Module` is created via header search (but not actually returned) and then gets queried directly from `ModuleMap` instead of `HeaderSearch`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113676/new/

https://reviews.llvm.org/D113676



More information about the cfe-commits mailing list