[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

[Jon Chesterfield via Phabricator via cfe-commits]

JonChesterfield added a subscriber: estewart08.
JonChesterfield added a comment.

Is the behaviour change in the above comments intentional? Pointed out by @estewart08



================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:9208
-                           FD->hasAttr<CUDAGlobalAttr>();
-  if ((IsOpenCLKernel || IsHIPKernel) &&
-      (M.getTriple().getOS() == llvm::Triple::AMDHSA))
----------------
Here, we skip the amdgpu-implicitarg-num-bytes and uniform-work-group-size assignments if FD is nullptr


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:9288
+
+  const bool IsOpenMP = M.getLangOpts().OpenMP && !FD;
+  if ((IsOpenCLKernel || IsHIPKernel || IsOpenMP) &&
----------------
Here, we do the amdgpu-implicitarg-num-bytes and uniform-work-group-size assignments regardless of whether FD is true or not


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113538/new/

https://reviews.llvm.org/D113538