[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

[Timm Bäder via Phabricator via cfe-commits]

tbaeder added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6625
+    auto ArgValue = StringRef(A->getValue());
+    auto FirstDashIndex = ArgValue.find('-');
+    auto Arg = ArgValue.substr(FirstDashIndex + 1);
----------------
MaskRay wrote:
> What if FirstDashIndex == std::string::npos?
Things still "work", but the plugin name then gets parsed incorrectly. I've decided to skip this case now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113250/new/

https://reviews.llvm.org/D113250