[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 17 18:43:49 PST 2021


MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

The idea LGTM. You need a test in `test/Driver` checking how the driver option maps to the CC1 option.

You may check whether `REQUIRES: plugins, examples` is needed.



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6625
+    auto ArgValue = StringRef(A->getValue());
+    auto FirstDashIndex = ArgValue.find('-');
+    auto Arg = ArgValue.substr(FirstDashIndex + 1);
----------------
What if FirstDashIndex == std::string::npos?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113250/new/

https://reviews.llvm.org/D113250



More information about the cfe-commits mailing list