[PATCH] D114095: [clang][lex][modules] Move number of includes from HeaderFileInfo to Preprocessor

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 17 12:51:18 PST 2021


dexonsmith added a comment.

I'm not sure this commit stands on its own, since it introduces a (temporary) regression in `.pcm` size; I suggest squashing with the follow-up, https://reviews.llvm.org/D114096.



================
Comment at: clang/include/clang/Lex/HeaderSearch.h:55
+  // TODO: Whether the file was imported is not a property of the file itself.
+  // It's a preprocessor state, move it there. 
   /// True if this is a \#import'd file.
----------------
Note that `clang-format` is complaining about a trailing space / ` ` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114095/new/

https://reviews.llvm.org/D114095



More information about the cfe-commits mailing list