[PATCH] D114088: [PowerPC] Add BCD add/sub/cmp builtins

[Victor Huang via Phabricator via cfe-commits]

NeHuang added a comment.

-



================
Comment at: clang/lib/Headers/altivec.h:19050
+}
+
+static __inline__ long __bcdcmpeq(vector unsigned char __a,
----------------
Do we need to add a case for "__CR6_SO_REV"? It is defined in line 25 but not used.


================
Comment at: llvm/lib/Target/PowerPC/P10InstrResources.td:2078
 )>;
+
----------------
nit: unrelated change


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5096
+        SubReg = PPC::sub_un;
+        ShiftVal = 0;
+        break;
----------------
can we remove this as default is 0?


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5100
+        SubReg = PPC::sub_un;
+        ShiftVal = 0;
+        Reverse = true;
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114088/new/

https://reviews.llvm.org/D114088