[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

Christian Kühnel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 17 04:51:48 PST 2021


kuhnel added a comment.

In D113902#3131707 <https://reviews.llvm.org/D113902#3131707>, @sammccall wrote:

> Hmm, clang-tidy should only be running on entries in compile_commands.json. are these files listed somehow?

No, they are not.

The question is: 
Do the tools our contributors use care about this? This is not the default behavior of clang-tidy, it's rather implemented in a LLVM-specific wrapper script. So do we require our contributors to use that script to check their code?

I was playing with the VS Code extension <https://marketplace.visualstudio.com/items?itemName=notskm.clang-tidy> to see the findings right in the IDE and that calls clang-tidy directly. So it ignores compile_commands.json


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113902/new/

https://reviews.llvm.org/D113902



More information about the cfe-commits mailing list