[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

This check was written specifically for the LLVM monorepo, I doubt there'll be consensus to disable it.
https://reviews.llvm.org/D72217 has some previous discussion - some people want the consts spelled out, but we don't do this in clangd.
And I don't particularly think that would be the right thing to do: it's throwing out the baby with the bathwater.

I think we should rather:

- fix the check to exempt strings (I don't think this would be terribly controversial, but I might be wrong)
- land a version of this patch that doesn't add `const` in the places we don't normally use it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113898/new/

https://reviews.llvm.org/D113898