[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

[Nathan Ridge via Phabricator via cfe-commits]

nridge added a comment.

Thanks for the patch.

Could you add a test exercising call hierarchy for obj-c methods to CallHierarchyTests.cpp <https://searchfox.org/llvm/source/clang-tools-extra/clangd/unittests/> please?

In terms of the actual change, this function has some other callers <https://searchfox.org/llvm/search?q=isFunctionOrFunctionTemplate&path=> in Parser and Sema code, and I don't know how this change will affect them. It may be better to limit the change to the clangd call site <https://searchfox.org/llvm/rev/098c01c132c8d14f08b847793afa045af5bb4522/clang-tools-extra/clangd/XRefs.cpp#1910> for now (that is, change that call site to use a local helper function, which checks `isFunctionOrFunctionTemplate() || <obj-c stuff>`), and defer changing `Decl::isFunctionOrFunctionTemplate()` itself to a subsequent refactor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114058/new/

https://reviews.llvm.org/D114058