[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

[Becca Royal-Gordon via Phabricator via cfe-commits]

beccadax requested changes to this revision.
beccadax added a comment.
This revision now requires changes to proceed.

err_lexing_string’s message is “failure when lexing a string” <https://github.com/llvm/llvm-project/blob/3e7ad1f2b2c0a753749eaba88d369d6032a50764/clang/include/clang/Basic/DiagnosticLexKinds.td#L272>, which isn’t accurate here since you’re lexing a character literal or numeric literal instead. Could you emit a more appropriate message for this? That might mean adding additional diagnostics or modifying the existing one so you can insert information about the kind of literal.

(err_lexing_string is only used for “can’t happen” errors, so maybe you could change the message to something like `“failure when lexing a %0 literal; a file may have been modified during compilation”`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114003/new/

https://reviews.llvm.org/D114003