[PATCH] D113892: [NFC][clangd] cleanup llvm-else-after-return findings

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 16 05:24:36 PST 2021


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Discussed offline, I believe the plan is to NOLINT the locations where we're handling several cases exhaustively.



================
Comment at: clang-tools-extra/clangd/Selection.cpp:350
       }
+      /* fall through and treat as part of the macro body */
     }
----------------
sammccall wrote:
> FWIW I find this one *much* less clear :-(
> I'd personally prefer to ignore the rule in this case, but curious what others think
I think this is a nolint


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113892/new/

https://reviews.llvm.org/D113892



More information about the cfe-commits mailing list