[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 16 01:14:39 PST 2021


JonChesterfield added a comment.

So you won't articulate or document the new invariant and you think there's a llvm-dev discussion that says we can't verify the invariant which you won't reference, but means you won't add this to the verifier.

Request changes doesn't really work after you've applied the patch.

@rnk do you object to me reverting this? I don't think we can add an invariant to IR which is undocumented and unverified/unverifiable and the patch author seems opposed to fixing either omission.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110257/new/

https://reviews.llvm.org/D110257



More information about the cfe-commits mailing list