[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

Mahesha S via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 16 00:27:06 PST 2021


hsmhsm added a comment.

In D110257#3133879 <https://reviews.llvm.org/D110257#3133879>, @JonChesterfield wrote:

> In D110257#3133866 <https://reviews.llvm.org/D110257#3133866>, @hsmhsm wrote:
>
>> This is not something specific to AMDGPU backend, but  AMDGPU backend at present requires this canonical form.
>
> Undocumented and not checked by the IR verifier. Canonical form seems to be overstating it until at least one of those is addressed.

We already discussed that this canonical form is not something that IR verifier can verify, but it is good enough for better code transformation/optimization. Please refer llvm-dev email discussion w.r.t it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110257/new/

https://reviews.llvm.org/D110257



More information about the cfe-commits mailing list