[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 15 13:32:02 PST 2021


aaron.ballman added reviewers: alexfh, whisperity.
aaron.ballman added a comment.

In D112646#3132141 <https://reviews.llvm.org/D112646#3132141>, @avogelsgesang wrote:

> @xazax.hun / @whisperity could you review this change for me, please :) 
> Or, alternatively: can you direct me to somebody who could review?

I've added a few more folks to the reviewer list just in case they're able to get to this before I am. FWIW, I was initially surprised that this is not in `modernize-` but the explanation about why the author wants it in `readability-` was compelling enough for me to think it's fine there. I haven't had the chance to give this a thorough review yet, but I like the general direction and appreciate the new check!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112646/new/

https://reviews.llvm.org/D112646



More information about the cfe-commits mailing list