[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

Fabian Wolff via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 15 13:30:51 PST 2021


fwolff marked an inline comment as done.
fwolff added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:20-23
+static const char ContainerExprName[] = "container-expr";
+static const char DerefContainerExprName[] = "deref-container-expr";
+static const char AddrofContainerExprName[] = "addrof-container-expr";
+static const char AddressOfName[] = "address-of";
----------------
whisperity wrote:
> Perhaps we could use `constexpr llvm::StringLiteral`?
Fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113863/new/

https://reviews.llvm.org/D113863



More information about the cfe-commits mailing list