[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp updated this revision to Diff 387304.
carlosgalvezp added a comment.

- Replace composition with private inheritance.
- Fix namespaces.

Public inheritance is not possible due to the base class' function being const-qualified; the derived class cannot be const since it updates state (unless we go into mutable territory, which I think goes in detriment of readability). What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113422/new/

https://reviews.llvm.org/D113422

Files:
  clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
  clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
  clang-tools-extra/clang-tidy/GlobList.cpp
  clang-tools-extra/clang-tidy/GlobList.h
  clang-tools-extra/unittests/clang-tidy/GlobListTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113422.387304.patch
Type: text/x-patch
Size: 6657 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211115/5412e4a8/attachment-0001.bin>