[PATCH] D113896: [NFC][clangd] cleanup of header guard names
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 15 07:40:25 PST 2021
sammccall added a comment.
Mostly LG, just a few files are test inputs and one is empty
================
Comment at: clang-tools-extra/clangd/test/Inputs/background-index/sub_dir/foo.h:1
-#ifndef FOO_H
-#define FOO_H
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_TEST_INPUTS_BACKGROUND_INDEX_SUB_DIR_FOO_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_TEST_INPUTS_BACKGROUND_INDEX_SUB_DIR_FOO_H
----------------
Please don't modify tests, they don't need to follow LLVM style and should be as simple as possible
================
Comment at: clang-tools-extra/clangd/test/index-serialization/Inputs/sample.h:1
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_TEST_INDEX_SERIALIZATION_INPUTS_SAMPLE_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_TEST_INDEX_SERIALIZATION_INPUTS_SAMPLE_H
----------------
In particular, adding header guards to test files without them isn't NFC
================
Comment at: clang-tools-extra/clangd/unittests/TestScheme.h:1
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_UNITTESTS_TESTSCHEME_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_UNITTESTS_TESTSCHEME_H
----------------
What's up with this change?
If this file is empty it should just be deleted instead
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113896/new/
https://reviews.llvm.org/D113896
More information about the cfe-commits
mailing list