[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Nov 14 17:24:15 PST 2021
Eugene.Zelenko added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyContext.cpp:40
+#include <vector>
+using namespace clang;
+using namespace tidy;
----------------
Shouldn't namespaces be used instead?
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyError.cpp:18
+#include "ClangTidyError.h"
+using namespace clang;
+using namespace tidy;
----------------
Shouldn't namespaces be used instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113848/new/
https://reviews.llvm.org/D113848
More information about the cfe-commits
mailing list