[PATCH] D113840: [Driver][Android] Remove unneeded isNoExecStackDefault

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 13 23:29:23 PST 2021


MaskRay created this revision.
MaskRay added reviewers: danalbert, pirama.
Herald added a subscriber: danielkiss.
MaskRay requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

ld.lld used by Android ignores .note.GNU-stack and defaults to noexecstack,
so the `-z noexecstack` linker option is unneeded.

The `--noexecstack` assembler option is unneeded because AsmPrinter.cpp
prints `.section .note.GNU-stack,"", at progbits` (when `llvm.init.trampoline` is unused),
so the assembler won't synthesize an executable .note.GNU-stack.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113840

Files:
  clang/include/clang/Driver/ToolChain.h
  clang/lib/Driver/ToolChain.cpp
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/lib/Driver/ToolChains/Gnu.cpp
  clang/lib/Driver/ToolChains/Linux.cpp
  clang/lib/Driver/ToolChains/Linux.h
  clang/test/Driver/integrated-as.c
  clang/test/Driver/linux-as.c
  clang/test/Driver/linux-ld.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113840.387059.patch
Type: text/x-patch
Size: 5633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211114/4d554001/attachment-0001.bin>


More information about the cfe-commits mailing list