[PATCH] D113794: Comment Sema: Use Name from CommandInfo for HeaderDoc diagnostics (NFC)

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 12 12:22:35 PST 2021


aaronpuchert created this revision.
aaronpuchert added a reviewer: gribozavr2.
aaronpuchert requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

We don't have to figure out the name, we can just fetch it from the
metadata table. Also there is no reason to %select over the names since
they're not natural language but keywords.

Subsequently we can focus on the actual logic and merge some branches
together. Unhandled cases are now marked unreachable, but this shouldn't
have any effect as of now. (We handle all existing commands.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113794

Files:
  clang/include/clang/AST/CommentCommands.td
  clang/include/clang/Basic/DiagnosticCommentKinds.td
  clang/lib/AST/CommentSema.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113794.386919.patch
Type: text/x-patch
Size: 8002 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211112/ddc6e600/attachment-0001.bin>


More information about the cfe-commits mailing list