[PATCH] D113793: Comment Sema: Run checks only when appropriate (NFC)

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 12 12:20:56 PST 2021


aaronpuchert created this revision.
aaronpuchert added a reviewer: gribozavr2.
aaronpuchert requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Instead of checking within the checks whether they apply, we check
before calling them. This allows us to fetch the CommandInfo only once
instead of for every check. Also eliminates some redundant checks and
deduplicates code in Sema::checkBlockCommandDuplicate.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113793

Files:
  clang/include/clang/AST/CommentSema.h
  clang/lib/AST/CommentSema.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113793.386918.patch
Type: text/x-patch
Size: 6428 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211112/b30b87cd/attachment.bin>


More information about the cfe-commits mailing list