[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 12 11:05:12 PST 2021


ldionne added a comment.

In D110216#3127530 <https://reviews.llvm.org/D110216#3127530>, @mizvekov wrote:

> Exactly what Aaron said :-)
>
> Though might be a complication here if libcxx tests this with both ToT and stable clang, so could be perhaps this needs to be changed in a way that works in both.
>
> I will check this much later today, having a busy day.
>
> Adding Louis for the libcxx expertise.

Thanks for the heads up, I'm thinking about a fix right now. I'll paste the diff here and you can incorporate it to this review, which should trigger libc++ CI and make sure everything works.

We should probably start running the libc++ CI on Clang changes systematically, but I'm somewhat concerned about the bandwidth of our CI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110216/new/

https://reviews.llvm.org/D110216



More information about the cfe-commits mailing list