[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

[Michael Benfield via Phabricator via cfe-commits]

mbenfield added inline comments.


================
Comment at: clang/test/Sema/attr-diagnose-as-builtin.c:62
+
+#ifdef __cplusplus
+template <class T>
----------------
george.burgess.iv wrote:
> nit: can we also add a non-templated overload check in here?
> 
> if the diag isn't beautiful, that's fine IMO. just having a test-case to show the expected behavior would be nice
Sorry, not sure what is being requested. By a "non-templated overload check" do you mean something different from `memcpy2` above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112024/new/

https://reviews.llvm.org/D112024