[PATCH] D51650: Implement target_clones multiversioning

[Daniel Kiss via Phabricator via cfe-commits]

danielkiss added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3290-3296
+  // Ensure we don't combine these with themselves, since that causes some
+  // confusing behavior.
+  if (const auto *Other = D->getAttr<TargetAttr>()) {
+    S.Diag(AL.getLoc(), diag::err_disallowed_duplicate_attribute) << AL;
+    S.Diag(Other->getLocation(), diag::note_conflicting_attribute);
+    return;
+  }
----------------
This caused the breakage. This check could be dropped for the reland.
target attributes seems can be combined, others shouldn't.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51650/new/

https://reviews.llvm.org/D51650