[PATCH] D113775: [clang][modules] Umbrella with missing submodule: unify implicit & explicit

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 12 07:32:32 PST 2021


jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Submodules not covered by existing umbrella header are being imported as textual with implicit modules. Explicit modules error out, since they still expect to be provided a module file that covers such header.

Unify the behavior of explicit modules with implicit modules by allowing such cases and treating them as textual as well.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113775

Files:
  clang/include/clang/Frontend/CompilerInstance.h
  clang/lib/Frontend/CompilerInstance.cpp
  clang/test/Modules/missing-submodule.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113775.386846.patch
Type: text/x-patch
Size: 5877 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211112/613a8c94/attachment.bin>


More information about the cfe-commits mailing list