[PATCH] D113765: [clangd] Fix function-arg-placeholder suppression with macros.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:476
         Completion.Kind == CompletionItemKind::Method ||
         Completion.Kind == CompletionItemKind::Constructor) {
       // If there is a potential template argument list, drop snippet and just
----------------
while here, i suppose we should perform drop arguments and parentheses magic for macros as well?


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:517
+        Completion.Kind == CompletionItemKind::Method ||
+        Completion.Kind == CompletionItemKind::Text /*Macro*/) {
       // Functions snippets can be of 2 types:
----------------
again while here, maybe introduce constructors into this condition. (Even better, what about a `bool isFunctionLikeCompletion(const CompletionItem&)` that we can use both here and above?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113765/new/

https://reviews.llvm.org/D113765