[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo
River Riddle via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 11 14:49:22 PST 2021
rriddle added inline comments.
================
Comment at: llvm/include/llvm/ADT/Hashing.h:59
namespace llvm {
-template <typename T> struct DenseMapInfo;
----------------
lattner wrote:
> Is there a way to keep the forward declarations references here instead of #include? DenseMapInfo.h pulls in a ton of stuff including <utility> and <tuple>
I mentioned it in a comment. If we don't want the includes, we'll need to sprinkle `void` everywhere that we specialize the template. (I don't have a preference either way)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113641/new/
https://reviews.llvm.org/D113641
More information about the cfe-commits
mailing list