[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards
Konrad Wilhelm Kleine via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 12 01:47:21 PST 2021
kwk added a comment.
You've disabled sized deallocation in some tests by providing `-fno-sized-deallocation `. I admit I haven't looked at those tests in detail but I would like to understand if those tests would otherwise fail. If they fail, is there work that needs to be done later to make them work again?
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6403
- // -fsized-deallocation is off by default, as it is an ABI-breaking change for
- // most platforms.
- if (Args.hasFlag(options::OPT_fsized_deallocation,
- options::OPT_fno_sized_deallocation, false))
+ // -fsized-deallocation is on by default in C++14 onwards and otherwise off
+ // by default.
@rjmccall mentioned [here](https://reviews.llvm.org/D8467#3125570) that
> Apple would like this to only be enabled conditionally based on deployment target.
Is this considered at all?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits