[PATCH] D112903: [C++20] [Module] Fix bug47716 and implement [module.interface]/p6

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 11 21:55:38 PST 2021


ChuanqiXu updated this revision to Diff 386728.
ChuanqiXu retitled this revision from "[C++20] [Module] Fix front end crashes when trying to export a qualified entity which is already declared" to "[C++20] [Module] Fix bug47716 and implement [module.interface]/p6".
ChuanqiXu edited the summary of this revision.
ChuanqiXu added a comment.

- Address comments.
- Implement [module.interface]/p6.

In the process of addressing @urnathan 's comment, I found that it is better to handle [module.interface]/p6 in Sema::CheckRedeclaration* functions. And I add more tests about p6 now. Now it looks much better now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112903/new/

https://reviews.llvm.org/D112903

Files:
  clang/include/clang/AST/DeclBase.h
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/include/clang/Sema/Sema.h
  clang/lib/AST/DeclBase.cpp
  clang/lib/Sema/SemaDecl.cpp
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/lib/Sema/SemaTemplate.cpp
  clang/test/CXX/module/module.interface/p2-2.cpp
  clang/test/CXX/module/module.interface/p6.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112903.386728.patch
Type: text/x-patch
Size: 12306 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211112/ab079b98/attachment-0001.bin>


More information about the cfe-commits mailing list