[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Thu Nov 11 08:08:10 PST 2021

azabaznov added inline comments.

================
Comment at: clang/lib/AST/ExprConstant.cpp:9554
+
+    const auto &OpenCLFeaturesMap =
+        Info.Ctx.getTargetInfo().getSupportedOpenCLOpts();
----------------
azabaznov wrote:
> Anastasia wrote:
> > What test case covers this change? It feels like something we should try to diagnose earlier...
> The test case which exactly was added. Since blocks in constant address space are disallowed at this point, we can treat all other blocks with no captures not as constant expressions - it will make CodeGen generate block  literal in local scope for blocks with no captures. See `buildGlobalBlock `and `CodeGenModule::GetAddrOfGlobalBlock` for details.
I mean - //blocks_no_global_literal.cl// - that's exactly the case which covers it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112230/new/

https://reviews.llvm.org/D112230