[PATCH] D112915: [clang][modules] Track number of includes per submodule
Volodymyr Sapsai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 10 18:51:16 PST 2021
vsapsai added a comment.
As we've discussed earlier, tracking `isImport` shouldn't be done per .pcm and here is the test case https://gist.github.com/vsapsai/a2d2bd19c54c24540495fd9b262106aa I'm not sure it is worth adding the second `#include` as the test fails just with one.
Overall, the change seems more complicated than it has to be. I need to check it carefully to see what can be simplified. And I need to check in debugger how and when AST reading is triggered. Looks like not all of that is lazy but I need to check the compiled code, not my guesses.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits