[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

Wed Nov 10 05:52:06 PST 2021

arsenm added a comment.

In D113538#3121062 <https://reviews.llvm.org/D113538#3121062>, @JonChesterfield wrote:

> That seems important. What was the symptom of failing to set these? We may now be redundantly setting some, e.g. 
> I think convergent is set somewhere else before this patch.

A bunch of missing attributes on the kernel. The one I noticed was not setting amdgpu-implicitarg-num-bytes (although D112488 <https://reviews.llvm.org/D112488> avoids needing to do that), but we have a few other attributes that simply wouldn't be set. I'm fighting with some divergence between upstream and the internal branches with these attributes. In particular, the internal branch is hacking on the generic attributes for openmp, and also redundantly (and incorrectly) setting amdgpu-flat-work-group-size to the invalid range 257,257.

convergent isn't a target attribute and isn't the target's responsibility to add.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113538/new/

https://reviews.llvm.org/D113538