[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)
Salman Javed via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 9 19:31:52 PST 2021
salman-javed-nz updated this revision to Diff 386047.
salman-javed-nz added a comment.
Revert to using simple string literals. I was being too clever for my own good with the Twine.
I think this should no longer cause ASan issues. WDYT?
This was meant to be a simple patch, so sorry for all the trouble.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113472/new/
https://reviews.llvm.org/D113472
Files:
clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
Index: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
===================================================================
--- clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
+++ clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
@@ -376,10 +376,10 @@
Context.getCurrentBuildDirectory(), false);
StringRef Message =
IsNolintBegin
- ? "unmatched 'NOLINTBEGIN' comment without a subsequent 'NOLINTEND' "
- "comment"
- : "unmatched 'NOLINTEND' comment without a previous 'NOLINTBEGIN' "
- "comment";
+ ? ("unmatched 'NOLINTBEGIN' comment without a subsequent 'NOLINT"
+ "END' comment")
+ : ("unmatched 'NOLINTEND' comment without a previous 'NOLINT"
+ "BEGIN' comment");
Error.Message = tooling::DiagnosticMessage(Message, SM, Loc);
return Error;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113472.386047.patch
Type: text/x-patch
Size: 905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211110/c0cec356/attachment.bin>
More information about the cfe-commits
mailing list