[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 9 14:45:25 PST 2021


tra added a comment.

Yes, we do need to merge identical functions with **identical names** for templates.

The comdat-folding issue is different. IIUIC, it allows merging two functions with identical code and **different names**, into one function with two names. That will break CUDA as we do need to have each stub to have a unique address as we use it to find the matching GPU-side kernel.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112492/new/

https://reviews.llvm.org/D112492



More information about the cfe-commits mailing list