[PATCH] D112868: [CodeGen] Diagnose and reject non-function ifunc resolvers

Itay Bookstein via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 9 13:46:55 PST 2021


ibookstein added a comment.

Yeah, it's real ugly from a CFE/LLVM separation POV. I also can't avoid seeing it as a duplication of the verifier's logic. But emitting diagnoses is better than asserting/crashing...
For the recursion, maybe an equivalent of `getAliaseeObject` on `GlobalDecl`-s could work? For the rest - not steeped in the code enough to say...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112868/new/

https://reviews.llvm.org/D112868



More information about the cfe-commits mailing list