[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

Tue Nov 9 10:07:57 PST 2021

asavonic added a comment.

In D98895#3118821 <https://reviews.llvm.org/D98895#3118821>, @eandrews wrote:

> This patch causes a regression.
>
> To reproduce - `clang -cc1 -fsycl-is-device -triple spir64 test.cpp`
>
>   test.cpp:x:3: error: 'bar<__float128>' requires 128 bit size '__float128' type support, but target 'spir64' does not support it
>   T bar() { return T(); };
>     ^
>
> I looked at it briefly, and I believe the issue is call to `checkTypeSupport()` in `ActOnFinishFunctionBody()`. I tried deleting the call but it breaks tests (E.g. L26 in x86_64-no-x87.cpp). @asavonic Please take a look. I will be reverting the patch if this cannot be fixed soon.

The diagnostic seems to be correct - this instance of `bar` returns an unsupported type. Why do you think it should not be diagnosed?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98895/new/

https://reviews.llvm.org/D98895