[PATCH] D113450: [clang-tidy] Fix llvm-header-guard so that it works with Windows paths

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 9 04:22:28 PST 2021


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, thank you for the fix!



================
Comment at: clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp:248-250
+      runHeaderGuardCheck(
+          "", "\\\\SambaShare\\llvm-project\\clang-tools-extra\\clangd\\foo.h",
+          StringRef("header is missing header guard")));
----------------
Another test case is UNC paths: `\\\\?\\C:\\llvm-project\\clang-tools-extra\\clangd\\foo.h` (with escapes already added).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113450/new/

https://reviews.llvm.org/D113450



More information about the cfe-commits mailing list